Repository navigation
Change ds, ts, etc. back to use logical date - #19088
Merged
Merged
Conversation
uranusjr
force-pushed
the
logical-date-in-templates
branch
from
October 19, 2021 19:30
f197c5f to
52e18f1
Compare
jedcunningham
left a comment
jedcunningham
left a comment
Member
There was a problem hiding this comment.
Looks good, I'm surprised this didn't need any test changes though?
Member
Author
|
Because all existing tests have matching |
uranusjr
force-pushed
the
logical-date-in-templates
branch
from
October 20, 2021 02:39
52e18f1 to
9165353
Compare
uranusjr
marked this pull request as ready for review
October 20, 2021 02:39
uranusjr
force-pushed
the
logical-date-in-templates
branch
from
October 20, 2021 02:40
9165353 to
b604a8f
Compare
Member
Author
|
Test added |
jedcunningham
approved these changes
Oct 20, 2021
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
jedcunningham
pushed a commit
that referenced
this pull request
Oct 20, 2021
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
(cherry picked from commit 25a50bb)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
24 of 37 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2021
(cherry picked from commit 25a50bb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of the step 1 as outlined in #19058 (comment)